fix(tests): update RESPONSE_PHASES assertion to match current turn_manager design

begin_combat/end_combat are dispatched as named priority windows inside
_phase_combat(), not as entries in RESPONSE_PHASES. The constant is
correctly {"upkeep", "end_step"} — test was asserting stale intent.
This commit is contained in:
KoalaTrapLord committed 2026-03-29 20:39:37 -04:00
1 parent 252e46b288
commit 75785ae918
1 file changed
+9 -2
+9 -2
View File
@@ -510,6 +510,13 @@ class TestTurnManagerPhaseCompat:
assert ACTION_PHASES == {"main1", "main2"}
def test_turn_manager_response_phases(self):
"""RESPONSE_PHASES should be upkeep, begin_combat, end_combat, end_step."""
"""RESPONSE_PHASES contains the instant-speed windows dispatched via _apnap_priority_window.
begin_combat and end_combat are handled as named calls inside _phase_combat()
directly -- they are NOT in RESPONSE_PHASES. Only upkeep and end_step
are dispatched through the generic APNAP window in _run_player_turn().
"""
from commander_ai_lab.sim.turn_manager import RESPONSE_PHASES
assert RESPONSE_PHASES == {"upkeep", "begin_combat", "end_combat", "end_step"}
assert RESPONSE_PHASES == {"upkeep", "end_step"}
assert "begin_combat" not in RESPONSE_PHASES
assert "end_combat" not in RESPONSE_PHASES