Consolidated 4-tool review (2 correctness agents + Codex + over-eng audit). Money-path (regression-tested): - _flatten_all: moved the fresh-broker close from close_session INTO the shared function + added a broker-held guard on entry cancellation, so the daily-loss CIRCUIT BREAKER (which called _flatten_all raw) no longer strips a just-filled bracket's legs or leaves a sync-gap fill naked. One guard, all callers. - restart state rebuild: _fresh_entries cap, _requested_symbols dedup, and losing benches now rebuild from today's events on boot — a mid-session restart no longer resets the cap to 0 or re-fires a resting order into a duplicate (the 2026-07-06 incident). - POST /orders no longer retries a lost-response URLError (was re-sending duplicate live orders); GET/DELETE still retry. - expire_stale_entries now @_locked (raced the trigger thread). - _session_open: ET conversion instead of a hardcoded 13:30-13:33Z window that only matched EDT — the fast path armed nothing all winter. Security: - admin panel fail-CLOSED on empty ADMIN_TOKEN (was fail-open on a panel fronting the docker socket); header-only token, constant-time compare. - admin API responses redact secret override VALUES (live keys would have echoed after a paper->live switch). - dashboard: removed wildcard CORS (cross-origin drive-by could drive trade actions); optional DASHBOARD_TOKEN gate on POST. Deletions (~805MB + dead code shipped in the prod image): momentum- rebuilt.zip, archive venv/htmlcov, and schwab/ core/ telemetry/ models/ runtime/providers/ storage/replay.py controlroom/ + three dead evaluation stubs + package.json — all verified zero-importer. +4 regression tests. 99 money-path/trigger/exit tests green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Deploying Momentum
Three supported shapes, one image/codebase. Pick by where it runs:
| Mode | Status | Use when | Docs |
|---|---|---|---|
| Docker Compose | ✅ canonical (production since 2026-07-09) | Any always-on Linux host; TrueNAS SCALE | docker/README.md, docker-compose.yml (root), docker/truenas-compose.yml |
| Local (systemd) | ✅ maintained | Development machine, WSL, bare metal without Docker | systemd/README.md + unit templates in deploy/systemd/ |
| Helm / Kubernetes | 🚧 planned refresh | Future k8s hosting | helm/ — the chart predates the 2026-07 architecture; starting point, not deployable |
Docker Compose (canonical)
The root docker-compose.yml runs the full stack self-contained: postgres 18,
trading loop, dashboard (:8765), admin panel (:8767), telegram bot, transcripts
pipeline, nightly scheduler, on-demand jobs, optional Grafana. The image is
published to docker.io/fez5587/momentum-app and ghcr.io/fez5587/momentum-app
by CI on every master push.
For TrueNAS SCALE use docker/truenas-compose.yml (pull-only, dataset host
paths, inline env). Read the gotchas in docker/README.md before editing the
YAML — anchor expansion, per-service env, and path case-sensitivity have each
caused an outage.
Local (systemd user services)
The original deployment: unit templates in deploy/systemd/ running a git
checkout + venv, config from .env. Still the best loop for development —
tests, backtests, and research scripts run here. Keep the units disabled
while the compose stack owns production: two loops against one Alpaca account
create duplicate orders.
Helm (future)
deploy/helm/ holds the original chart (single app deployment + CronJobs). It
predates the service split, the session gate, and the env-flag inventory; the
refresh is tracked in GitHub issues. Until then, compose is the way.
Config in all modes
.env.example(committed, sanitized) is the full variable inventory and says which layer each belongs in.- Behavior flags that MUST be set explicitly in any deployment — silent
defaults bite:
TRADING_AUTO_APPROVE=1(else entries queue for manual approval),ALPACA_DATA_FEED=sip,OLLAMA_ENABLED=true(catalyst engine),FMP_API_KEY(float cache).TRADING_SESSION_ONLYdefaults ON in deployed configs (bars after-hours entries). - Runtime overrides: the admin panel writes
data/overrides.env, which every service loads over its baked env at boot (runtime/env_overrides.py).