ClaudeandClaude Opus 4.6
77ded23aef
BUG-01: Unknown cards no longer default to "Creature". enrich_card() now sets type_line="Unknown" for cards without Scryfall data. Added can_attack_or_block() method to Card — only cards with "Creature" in type_line can participate in combat. Engine combat uses can_attack_or_block() instead of is_creature(). BUG-02: Implemented get_legal_moves() and apply_move() in CommanderGameState with actual game logic — land drops, spell casting (with mana checking), commander casting from command zone, attack declarations, and instant-speed responses. Replaces the former pass-only stubs. BUG-05: Instants and sorceries now go to graveyard after resolution instead of being placed on the battlefield as permanents. Added is_permanent(), is_instant(), is_sorcery() helpers to Card model. Includes 48 new regression tests covering all three bugs plus integration tests verifying artifacts/unknown cards never appear in combat. Fixed existing test_engine.py to match current engine API. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
104 lines
3.2 KiB
Python
104 lines
3.2 KiB
Python
"""Seeded simulation tests for the game engine."""
|
|
import random
|
|
import pytest
|
|
from commander_ai_lab.sim.models import Card, Player, PlayerStats
|
|
from commander_ai_lab.sim.rules import enrich_card
|
|
from commander_ai_lab.sim.engine import GameEngine
|
|
|
|
|
|
def _make_deck(seed: int, size: int = 60) -> list[Card]:
|
|
"""Build a deterministic test deck using a seeded RNG."""
|
|
rng = random.Random(seed)
|
|
card_pool = [
|
|
Card(name="Forest"),
|
|
Card(name="Sol Ring"),
|
|
Card(name="Cultivate"),
|
|
Card(name="Murder"),
|
|
Card(name="Wrath of God"),
|
|
Card(name="Grizzly Bears", type_line="Creature — Bear", cmc=2, pt="2/2"),
|
|
Card(name="Serra Angel", type_line="Creature — Angel", cmc=5, pt="4/4",
|
|
keywords=["Flying", "Vigilance"]),
|
|
]
|
|
for c in card_pool:
|
|
enrich_card(c)
|
|
deck = []
|
|
for i in range(size):
|
|
deck.append(card_pool[i % len(card_pool)].clone())
|
|
rng.shuffle(deck)
|
|
return deck
|
|
|
|
|
|
class TestGameEngineTwoPlayer:
|
|
def test_game_completes(self):
|
|
"""A 2-player game should finish without error."""
|
|
random.seed(42)
|
|
engine = GameEngine(max_turns=25)
|
|
deck_a = _make_deck(seed=1)
|
|
deck_b = _make_deck(seed=2)
|
|
result = engine.run(
|
|
deck_a=[c.clone() for c in deck_a],
|
|
deck_b=[c.clone() for c in deck_b],
|
|
name_a="Alice",
|
|
name_b="Bob",
|
|
)
|
|
assert result is not None
|
|
assert result.turns > 0
|
|
|
|
def test_result_has_winner_or_draw(self):
|
|
"""winner_seat must be 0, 1, or -1 (draw)."""
|
|
random.seed(99)
|
|
engine = GameEngine(max_turns=25)
|
|
deck = _make_deck(seed=5)
|
|
result = engine.run(
|
|
deck_a=[c.clone() for c in deck],
|
|
deck_b=[c.clone() for c in deck],
|
|
name_a="P1",
|
|
name_b="P2",
|
|
)
|
|
assert result.winner_seat in (-1, 0, 1)
|
|
|
|
def test_seeded_game_is_deterministic(self):
|
|
"""Same seed must produce identical results."""
|
|
deck_a = _make_deck(seed=7)
|
|
deck_b = _make_deck(seed=8)
|
|
|
|
random.seed(42)
|
|
engine1 = GameEngine(max_turns=25)
|
|
result1 = engine1.run(
|
|
deck_a=[c.clone() for c in deck_a],
|
|
deck_b=[c.clone() for c in deck_b],
|
|
name_a="Alice",
|
|
name_b="Bob",
|
|
)
|
|
|
|
random.seed(42)
|
|
engine2 = GameEngine(max_turns=25)
|
|
result2 = engine2.run(
|
|
deck_a=[c.clone() for c in deck_a],
|
|
deck_b=[c.clone() for c in deck_b],
|
|
name_a="Alice",
|
|
name_b="Bob",
|
|
)
|
|
|
|
assert result1.winner_seat == result2.winner_seat
|
|
assert result1.turns == result2.turns
|
|
|
|
def test_to_dict_serializable(self):
|
|
"""Game result must serialize to a dict with expected keys."""
|
|
import json
|
|
random.seed(77)
|
|
engine = GameEngine(max_turns=25)
|
|
deck = _make_deck(seed=3)
|
|
result = engine.run(
|
|
deck_a=[c.clone() for c in deck],
|
|
deck_b=[c.clone() for c in deck],
|
|
name_a="A",
|
|
name_b="B",
|
|
)
|
|
d = result.to_dict()
|
|
assert "winner" in d
|
|
assert "turns" in d
|
|
assert "playerResults" in d
|
|
# Ensure it's JSON-serializable
|
|
json.dumps(d)
|