From bd9443599337a20fa06e4ba1bd6547c0bda76fe2 Mon Sep 17 00:00:00 2001 From: Claude Date: Tue, 24 Mar 2026 02:53:40 +0000 Subject: [PATCH] cleanup: remove unused imports, merge duplicates, drop stale comment - Remove unused _ml_logging_enabled import from routes/deepseek.py - Remove dead _ml_logging_enabled top-level import and _ml_logging_enabled_local alias from routes/ml.py (endpoints already use the module-path form via import services.logging) - Merge duplicate from services.precon_service imports in routes/precon.py - Merge duplicate from models.requests imports in routes/deckgen.py - Remove redundant inline comment in routes/precon.py Co-Authored-By: Claude Opus 4.6 --- routes/deckgen.py | 4 +--- routes/deepseek.py | 2 +- routes/ml.py | 5 ----- routes/precon.py | 5 ++--- 4 files changed, 4 insertions(+), 12 deletions(-) diff --git a/routes/deckgen.py b/routes/deckgen.py index 459a88c..ee6b1db 100644 --- a/routes/deckgen.py +++ b/routes/deckgen.py @@ -33,13 +33,11 @@ import httpx from fastapi import APIRouter, HTTPException from fastapi.responses import JSONResponse, StreamingResponse -from models.requests import DeckResearchRequest, DeckGenerateAIRequest - import routes.coach as _coach # for _deck_gen_v3 / _deck_gen_v3_error module-level access from models.state import CFG from models.requests import ( DeckGenerationRequest, DeckGenV3Request, DeckGenV3SubstituteRequest, - DeckGenerationSourceConfig, + DeckGenerationSourceConfig, DeckResearchRequest, DeckGenerateAIRequest, ) from models.responses import GeneratedDeckCard from services.database import _get_db_conn diff --git a/routes/deepseek.py b/routes/deepseek.py index 2873933..9f6564c 100644 --- a/routes/deepseek.py +++ b/routes/deepseek.py @@ -31,7 +31,7 @@ from fastapi.responses import JSONResponse from models.state import CFG from services.database import _get_db_conn from services.forge_runner import _get_deepseek_brain -from services.logging import log_sim, _ml_logging_enabled +from services.logging import log_sim from commander_ai_lab.sim.validator_brain import ValidatorBrain, ValidatorConfig logger = logging.getLogger(__name__) diff --git a/routes/ml.py b/routes/ml.py index cb6a3b2..ad276ce 100644 --- a/routes/ml.py +++ b/routes/ml.py @@ -33,8 +33,6 @@ from pathlib import Path from fastapi import APIRouter, HTTPException, Request as FastAPIRequest from models.state import CFG -from services.logging import _ml_logging_enabled - log_ml = logging.getLogger("commander_ai_lab.ml") router = APIRouter(tags=["ml"]) @@ -94,9 +92,6 @@ _ppo_lock = threading.Lock() _tournament_state = _TournamentState() _tournament_lock = threading.Lock() -# module-level toggle (local copy; the shared one is for batch runs) -_ml_logging_enabled_local = _ml_logging_enabled - def _get_policy_service(): """Get or initialize the policy inference service (lazy loading).""" diff --git a/routes/precon.py b/routes/precon.py index 3c1f39d..846f686 100644 --- a/routes/precon.py +++ b/routes/precon.py @@ -16,9 +16,8 @@ from pathlib import Path from fastapi import APIRouter, HTTPException from models.state import CFG -from services.precon_service import download_precon_database, PRECON_INDEX +from services.precon_service import download_precon_database, PRECON_INDEX, _get_precon_dir from services.logging import log -from services.precon_service import _get_precon_dir router = APIRouter(tags=["precon"]) @@ -26,7 +25,7 @@ router = APIRouter(tags=["precon"]) @router.get("/api/lab/precons") async def list_precons(): """List all available precon decks.""" - return {"precons": PRECON_INDEX} # reads current value every call + return {"precons": PRECON_INDEX} @router.post("/api/lab/precons/install")