fez5587/commander-ai-lab
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: early return in _load_deck_cards_by_name when deck not found in DB

Browse Source 
Fixes UnboundLocalError crash when deck_row is None by returning an
empty list instead of falling through to a query with an unbound deck_id.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
ClaudeandClaude Opus 4.6 committed 2026-03-22 07:25:39 +00:00
1 parent 8c2a8cf1c1
commit 978fb12969
1 file changed
+3 -2
Download Patch File Download Diff File Expand all files Collapse all files
services/deck_service.py
+3 -2
View File
@@ -178,8 +178,9 @@ def _load_deck_cards_by_name(deck_name: str) -> list:
"""Load cards from a deck by name, returning list of card dicts.""" """Load cards from a deck by name, returning list of card dicts."""
conn = _get_db_conn() conn = _get_db_conn()
deck_row = conn.execute("SELECT id FROM decks WHERE name = ?", (deck_name,)).fetchone() deck_row = conn.execute("SELECT id FROM decks WHERE name = ?", (deck_name,)).fetchone()
if deck_row: if not deck_row:
deck_id = deck_row[0] return []
deck_id = deck_row[0]
rows = conn.execute(""" rows = conn.execute("""
SELECT dc.card_name, dc.quantity, dc.is_commander, dc.role_tag, dc.scryfall_id, SELECT dc.card_name, dc.quantity, dc.is_commander, dc.role_tag, dc.scryfall_id,
COALESCE(ce.type_line, cr.type_line, '') as type_line, COALESCE(ce.type_line, cr.type_line, '') as type_line,