From b83801cd1d2d2c4d56a75a6c8315a7001cb25d4f Mon Sep 17 00:00:00 2001 From: Luis Fernando Molina Date: Fri, 3 Dec 2021 21:47:01 +0100 Subject: [PATCH 1/4] BUG FIX: Negative Percentage Enabled Creating Token Power --- .../Governance/UI/Function-Libraries/ClaimsProgram.js | 8 ++++---- .../Governance/UI/Function-Libraries/DelegationProgram.js | 8 ++++---- Projects/Governance/UI/Function-Libraries/TokenPower.js | 8 ++++---- .../Governance/UI/Function-Libraries/VotingProgram.js | 8 ++++---- Projects/Governance/UI/Utilities/DecendentProgram.js | 4 ++-- 5 files changed, 18 insertions(+), 18 deletions(-) diff --git a/Projects/Governance/UI/Function-Libraries/ClaimsProgram.js b/Projects/Governance/UI/Function-Libraries/ClaimsProgram.js index d998e790e..329afc4a9 100644 --- a/Projects/Governance/UI/Function-Libraries/ClaimsProgram.js +++ b/Projects/Governance/UI/Function-Libraries/ClaimsProgram.js @@ -326,7 +326,7 @@ function newGovernanceFunctionLibraryClaimsProgram() { if (childNode.type === "Tokens Awarded") { continue } let percentage = UI.projects.visualScripting.utilities.nodeConfig.loadConfigProperty(childNode.payload, 'percentage') - if (percentage !== undefined && isNaN(percentage) !== true) { + if (percentage !== undefined && isNaN(percentage > 0) && percentage !== true) { totalPercentage = totalPercentage + percentage } else { totalNodesWithoutPercentage++ @@ -342,7 +342,7 @@ function newGovernanceFunctionLibraryClaimsProgram() { if (childNode.type === "Tokens Awarded") { continue } let percentage = UI.projects.visualScripting.utilities.nodeConfig.loadConfigProperty(childNode.payload, 'percentage') - if (percentage !== undefined && isNaN(percentage) !== true) { + if (percentage !== undefined && isNaN(percentage > 0) && percentage !== true) { totalPercentage = totalPercentage + percentage } else { totalNodesWithoutPercentage++ @@ -373,7 +373,7 @@ function newGovernanceFunctionLibraryClaimsProgram() { if (childNode.type === "Tokens Awarded") { continue } let percentage = UI.projects.visualScripting.utilities.nodeConfig.loadConfigProperty(childNode.payload, 'percentage') - if (percentage === undefined || isNaN(percentage) === true) { + if (percentage === undefined || isNaN(percentage) || percentage < 0 === true) { percentage = defaultPercentage } distributeProgramPower(childNode, programPower * percentage / 100, percentage) @@ -388,7 +388,7 @@ function newGovernanceFunctionLibraryClaimsProgram() { if (childNode.type === "Tokens Awarded") { continue } let percentage = UI.projects.visualScripting.utilities.nodeConfig.loadConfigProperty(childNode.payload, 'percentage') - if (percentage === undefined || isNaN(percentage) === true) { + if (percentage === undefined || isNaN(percentage) || percentage < 0 === true) { percentage = defaultPercentage } distributeProgramPower(childNode, programPower * percentage / 100, percentage) diff --git a/Projects/Governance/UI/Function-Libraries/DelegationProgram.js b/Projects/Governance/UI/Function-Libraries/DelegationProgram.js index b62b46d38..f73803ebf 100644 --- a/Projects/Governance/UI/Function-Libraries/DelegationProgram.js +++ b/Projects/Governance/UI/Function-Libraries/DelegationProgram.js @@ -184,7 +184,7 @@ function newGovernanceFunctionLibraryDelegationProgram() { if (childNode === undefined) { continue } if (childNode.type === 'Tokens Bonus') { continue } let percentage = UI.projects.visualScripting.utilities.nodeConfig.loadConfigProperty(childNode.payload, 'percentage') - if (percentage !== undefined && isNaN(percentage) !== true) { + if (percentage !== undefined && isNaN(percentage > 0) && percentage !== true) { totalPercentage = totalPercentage + percentage } else { totalNodesWithoutPercentage++ @@ -199,7 +199,7 @@ function newGovernanceFunctionLibraryDelegationProgram() { if (childNode === undefined) { continue } if (childNode.type === 'Tokens Bonus') { continue } let percentage = UI.projects.visualScripting.utilities.nodeConfig.loadConfigProperty(childNode.payload, 'percentage') - if (percentage !== undefined && isNaN(percentage) !== true) { + if (percentage !== undefined && isNaN(percentage > 0) && percentage !== true) { totalPercentage = totalPercentage + percentage } else { totalNodesWithoutPercentage++ @@ -233,7 +233,7 @@ function newGovernanceFunctionLibraryDelegationProgram() { if (childNode === undefined) { continue } if (childNode.type === 'Tokens Bonus') { continue } let percentage = UI.projects.visualScripting.utilities.nodeConfig.loadConfigProperty(childNode.payload, 'percentage') - if (percentage === undefined || isNaN(percentage) === true) { + if (percentage === undefined || isNaN(percentage) || percentage < 0 === true) { percentage = defaultPercentage } distributeProgramPower( @@ -253,7 +253,7 @@ function newGovernanceFunctionLibraryDelegationProgram() { if (childNode === undefined) { continue } if (childNode.type === 'Tokens Bonus') { continue } let percentage = UI.projects.visualScripting.utilities.nodeConfig.loadConfigProperty(childNode.payload, 'percentage') - if (percentage === undefined || isNaN(percentage) === true) { + if (percentage === undefined || isNaN(percentage) || percentage < 0 === true) { percentage = defaultPercentage } distributeProgramPower( diff --git a/Projects/Governance/UI/Function-Libraries/TokenPower.js b/Projects/Governance/UI/Function-Libraries/TokenPower.js index cf2fa905a..cf26cd47f 100644 --- a/Projects/Governance/UI/Function-Libraries/TokenPower.js +++ b/Projects/Governance/UI/Function-Libraries/TokenPower.js @@ -191,7 +191,7 @@ function newGovernanceFunctionLibraryTokenPower() { let percentage = getPercentage(childNode) - if (percentage !== undefined && isNaN(percentage) !== true) { + if (percentage !== undefined && isNaN(percentage > 0) && percentage !== true) { totalPercentage = totalPercentage + percentage } else { totalNodesWithoutPercentage++ @@ -208,7 +208,7 @@ function newGovernanceFunctionLibraryTokenPower() { if (OPAQUE_NODES_TYPES.includes(childNode.type)) { continue } let percentage = getPercentage(childNode) - if (percentage !== undefined && isNaN(percentage) !== true) { + if (percentage !== undefined && isNaN(percentage > 0) && percentage !== true) { totalPercentage = totalPercentage + percentage } else { totalNodesWithoutPercentage++ @@ -244,7 +244,7 @@ function newGovernanceFunctionLibraryTokenPower() { if (OPAQUE_NODES_TYPES.includes(childNode.type)) { continue } let percentage = getPercentage(childNode) - if (percentage === undefined || isNaN(percentage) === true) { + if (percentage === undefined || isNaN(percentage) || percentage < 0 === true) { percentage = defaultPercentage } distributeTokenPower( @@ -265,7 +265,7 @@ function newGovernanceFunctionLibraryTokenPower() { if (OPAQUE_NODES_TYPES.includes(childNode.type)) { continue } let percentage = getPercentage(childNode) - if (percentage === undefined || isNaN(percentage) === true) { + if (percentage === undefined || isNaN(percentage) || percentage < 0 === true) { percentage = defaultPercentage } distributeTokenPower( diff --git a/Projects/Governance/UI/Function-Libraries/VotingProgram.js b/Projects/Governance/UI/Function-Libraries/VotingProgram.js index 5d8c3cd20..57ebbd56f 100644 --- a/Projects/Governance/UI/Function-Libraries/VotingProgram.js +++ b/Projects/Governance/UI/Function-Libraries/VotingProgram.js @@ -331,7 +331,7 @@ function newGovernanceFunctionLibraryVotingProgram() { if (childNode === undefined) { continue } if (childNode.type === 'Tokens Bonus') { continue } let percentage = UI.projects.visualScripting.utilities.nodeConfig.loadConfigProperty(childNode.payload, 'percentage') - if (percentage !== undefined && isNaN(percentage) !== true) { + if (percentage !== undefined && isNaN(percentage > 0) && percentage !== true) { totalPercentage = totalPercentage + percentage } else { totalNodesWithoutPercentage++ @@ -346,7 +346,7 @@ function newGovernanceFunctionLibraryVotingProgram() { if (childNode === undefined) { continue } if (childNode.type === 'Tokens Bonus') { continue } let percentage = UI.projects.visualScripting.utilities.nodeConfig.loadConfigProperty(childNode.payload, 'percentage') - if (percentage !== undefined && isNaN(percentage) !== true) { + if (percentage !== undefined && isNaN(percentage > 0) && percentage !== true) { totalPercentage = totalPercentage + percentage } else { totalNodesWithoutPercentage++ @@ -380,7 +380,7 @@ function newGovernanceFunctionLibraryVotingProgram() { if (childNode === undefined) { continue } if (childNode.type === 'Tokens Bonus') { continue } let percentage = UI.projects.visualScripting.utilities.nodeConfig.loadConfigProperty(childNode.payload, 'percentage') - if (percentage === undefined || isNaN(percentage) === true) { + if (percentage === undefined || isNaN(percentage) || percentage < 0 === true) { percentage = defaultPercentage } distributeProgramPower( @@ -401,7 +401,7 @@ function newGovernanceFunctionLibraryVotingProgram() { if (childNode === undefined) { continue } if (childNode.type === 'Tokens Bonus') { continue } let percentage = UI.projects.visualScripting.utilities.nodeConfig.loadConfigProperty(childNode.payload, 'percentage') - if (percentage === undefined || isNaN(percentage) === true) { + if (percentage === undefined || isNaN(percentage) || percentage < 0 === true) { percentage = defaultPercentage } distributeProgramPower( diff --git a/Projects/Governance/UI/Utilities/DecendentProgram.js b/Projects/Governance/UI/Utilities/DecendentProgram.js index 61f0b6370..2407fda33 100644 --- a/Projects/Governance/UI/Utilities/DecendentProgram.js +++ b/Projects/Governance/UI/Utilities/DecendentProgram.js @@ -283,7 +283,7 @@ function newGovernanceUtilitiesDecendentProgram() { for (let i = 0; i < node[usersArrayPropertyName].length; i++) { let childNode = node[usersArrayPropertyName][i] let percentage = UI.projects.visualScripting.utilities.nodeConfig.loadConfigProperty(childNode.payload, 'percentage') - if (percentage !== undefined && isNaN(percentage) !== true) { + if (percentage !== undefined && isNaN(percentage > 0) && percentage !== true) { totalPercentage = totalPercentage + percentage } else { totalNodesWithoutPercentage++ @@ -306,7 +306,7 @@ function newGovernanceUtilitiesDecendentProgram() { for (let i = 0; i < node[usersArrayPropertyName].length; i++) { let childNode = node[usersArrayPropertyName][i] let percentage = UI.projects.visualScripting.utilities.nodeConfig.loadConfigProperty(childNode.payload, 'percentage') - if (percentage === undefined || isNaN(percentage) === true) { + if (percentage === undefined || isNaN(percentage) || percentage < 0 === true) { percentage = defaultPercentage } distributeProgramPower( From babc2e0a4287c7bc2497b88010edc5151ce8df38 Mon Sep 17 00:00:00 2001 From: Luis Fernando Molina Date: Fri, 3 Dec 2021 21:51:21 +0100 Subject: [PATCH 2/4] Deep Scan Bug Fixes --- Projects/Governance/UI/Function-Libraries/TokenPower.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Projects/Governance/UI/Function-Libraries/TokenPower.js b/Projects/Governance/UI/Function-Libraries/TokenPower.js index cf26cd47f..474e90f98 100644 --- a/Projects/Governance/UI/Function-Libraries/TokenPower.js +++ b/Projects/Governance/UI/Function-Libraries/TokenPower.js @@ -191,7 +191,7 @@ function newGovernanceFunctionLibraryTokenPower() { let percentage = getPercentage(childNode) - if (percentage !== undefined && isNaN(percentage > 0) && percentage !== true) { + if (percentage !== undefined && isNaN(percentage) && percentage > 0 !== true) { totalPercentage = totalPercentage + percentage } else { totalNodesWithoutPercentage++ @@ -208,7 +208,7 @@ function newGovernanceFunctionLibraryTokenPower() { if (OPAQUE_NODES_TYPES.includes(childNode.type)) { continue } let percentage = getPercentage(childNode) - if (percentage !== undefined && isNaN(percentage > 0) && percentage !== true) { + if (percentage !== undefined && isNaN(percentage) && percentage > 0 !== true) { totalPercentage = totalPercentage + percentage } else { totalNodesWithoutPercentage++ From c6f34e97e10ceb2bb48d8136ebb5d097630e922f Mon Sep 17 00:00:00 2001 From: Luis Fernando Molina Date: Fri, 3 Dec 2021 21:52:18 +0100 Subject: [PATCH 3/4] Deep Scan Bug Fixes --- Projects/Governance/UI/Function-Libraries/ClaimsProgram.js | 4 ++-- .../Governance/UI/Function-Libraries/DelegationProgram.js | 4 ++-- Projects/Governance/UI/Function-Libraries/VotingProgram.js | 4 ++-- Projects/Governance/UI/Utilities/DecendentProgram.js | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/Projects/Governance/UI/Function-Libraries/ClaimsProgram.js b/Projects/Governance/UI/Function-Libraries/ClaimsProgram.js index 329afc4a9..c80a56222 100644 --- a/Projects/Governance/UI/Function-Libraries/ClaimsProgram.js +++ b/Projects/Governance/UI/Function-Libraries/ClaimsProgram.js @@ -326,7 +326,7 @@ function newGovernanceFunctionLibraryClaimsProgram() { if (childNode.type === "Tokens Awarded") { continue } let percentage = UI.projects.visualScripting.utilities.nodeConfig.loadConfigProperty(childNode.payload, 'percentage') - if (percentage !== undefined && isNaN(percentage > 0) && percentage !== true) { + if (percentage !== undefined && isNaN(percentage) && percentage > 0 !== true) { totalPercentage = totalPercentage + percentage } else { totalNodesWithoutPercentage++ @@ -342,7 +342,7 @@ function newGovernanceFunctionLibraryClaimsProgram() { if (childNode.type === "Tokens Awarded") { continue } let percentage = UI.projects.visualScripting.utilities.nodeConfig.loadConfigProperty(childNode.payload, 'percentage') - if (percentage !== undefined && isNaN(percentage > 0) && percentage !== true) { + if (percentage !== undefined && isNaN(percentage) && percentage > 0 !== true) { totalPercentage = totalPercentage + percentage } else { totalNodesWithoutPercentage++ diff --git a/Projects/Governance/UI/Function-Libraries/DelegationProgram.js b/Projects/Governance/UI/Function-Libraries/DelegationProgram.js index f73803ebf..160f563e6 100644 --- a/Projects/Governance/UI/Function-Libraries/DelegationProgram.js +++ b/Projects/Governance/UI/Function-Libraries/DelegationProgram.js @@ -184,7 +184,7 @@ function newGovernanceFunctionLibraryDelegationProgram() { if (childNode === undefined) { continue } if (childNode.type === 'Tokens Bonus') { continue } let percentage = UI.projects.visualScripting.utilities.nodeConfig.loadConfigProperty(childNode.payload, 'percentage') - if (percentage !== undefined && isNaN(percentage > 0) && percentage !== true) { + if (percentage !== undefined && isNaN(percentage) && percentage > 0 !== true) { totalPercentage = totalPercentage + percentage } else { totalNodesWithoutPercentage++ @@ -199,7 +199,7 @@ function newGovernanceFunctionLibraryDelegationProgram() { if (childNode === undefined) { continue } if (childNode.type === 'Tokens Bonus') { continue } let percentage = UI.projects.visualScripting.utilities.nodeConfig.loadConfigProperty(childNode.payload, 'percentage') - if (percentage !== undefined && isNaN(percentage > 0) && percentage !== true) { + if (percentage !== undefined && isNaN(percentage) && percentage > 0 !== true) { totalPercentage = totalPercentage + percentage } else { totalNodesWithoutPercentage++ diff --git a/Projects/Governance/UI/Function-Libraries/VotingProgram.js b/Projects/Governance/UI/Function-Libraries/VotingProgram.js index 57ebbd56f..cc633864c 100644 --- a/Projects/Governance/UI/Function-Libraries/VotingProgram.js +++ b/Projects/Governance/UI/Function-Libraries/VotingProgram.js @@ -331,7 +331,7 @@ function newGovernanceFunctionLibraryVotingProgram() { if (childNode === undefined) { continue } if (childNode.type === 'Tokens Bonus') { continue } let percentage = UI.projects.visualScripting.utilities.nodeConfig.loadConfigProperty(childNode.payload, 'percentage') - if (percentage !== undefined && isNaN(percentage > 0) && percentage !== true) { + if (percentage !== undefined && isNaN(percentage) && percentage > 0 !== true) { totalPercentage = totalPercentage + percentage } else { totalNodesWithoutPercentage++ @@ -346,7 +346,7 @@ function newGovernanceFunctionLibraryVotingProgram() { if (childNode === undefined) { continue } if (childNode.type === 'Tokens Bonus') { continue } let percentage = UI.projects.visualScripting.utilities.nodeConfig.loadConfigProperty(childNode.payload, 'percentage') - if (percentage !== undefined && isNaN(percentage > 0) && percentage !== true) { + if (percentage !== undefined && isNaN(percentage) && percentage > 0 !== true) { totalPercentage = totalPercentage + percentage } else { totalNodesWithoutPercentage++ diff --git a/Projects/Governance/UI/Utilities/DecendentProgram.js b/Projects/Governance/UI/Utilities/DecendentProgram.js index 2407fda33..7c13159a1 100644 --- a/Projects/Governance/UI/Utilities/DecendentProgram.js +++ b/Projects/Governance/UI/Utilities/DecendentProgram.js @@ -283,7 +283,7 @@ function newGovernanceUtilitiesDecendentProgram() { for (let i = 0; i < node[usersArrayPropertyName].length; i++) { let childNode = node[usersArrayPropertyName][i] let percentage = UI.projects.visualScripting.utilities.nodeConfig.loadConfigProperty(childNode.payload, 'percentage') - if (percentage !== undefined && isNaN(percentage > 0) && percentage !== true) { + if (percentage !== undefined && isNaN(percentage) && percentage > 0 !== true) { totalPercentage = totalPercentage + percentage } else { totalNodesWithoutPercentage++ From 38706a46153ee2211198a7a197f2446562e19c34 Mon Sep 17 00:00:00 2001 From: Luis Fernando Molina Date: Fri, 3 Dec 2021 22:02:16 +0100 Subject: [PATCH 4/4] Deep Scan Bug Fixes --- Projects/Governance/UI/Function-Libraries/ClaimsProgram.js | 4 ++-- .../Governance/UI/Function-Libraries/DelegationProgram.js | 4 ++-- Projects/Governance/UI/Function-Libraries/TokenPower.js | 4 ++-- Projects/Governance/UI/Function-Libraries/VotingProgram.js | 4 ++-- Projects/Governance/UI/Utilities/DecendentProgram.js | 2 +- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/Projects/Governance/UI/Function-Libraries/ClaimsProgram.js b/Projects/Governance/UI/Function-Libraries/ClaimsProgram.js index c80a56222..a8f35eb1d 100644 --- a/Projects/Governance/UI/Function-Libraries/ClaimsProgram.js +++ b/Projects/Governance/UI/Function-Libraries/ClaimsProgram.js @@ -326,7 +326,7 @@ function newGovernanceFunctionLibraryClaimsProgram() { if (childNode.type === "Tokens Awarded") { continue } let percentage = UI.projects.visualScripting.utilities.nodeConfig.loadConfigProperty(childNode.payload, 'percentage') - if (percentage !== undefined && isNaN(percentage) && percentage > 0 !== true) { + if (percentage !== undefined && isNaN(percentage) !== true && percentage >= 0) { totalPercentage = totalPercentage + percentage } else { totalNodesWithoutPercentage++ @@ -342,7 +342,7 @@ function newGovernanceFunctionLibraryClaimsProgram() { if (childNode.type === "Tokens Awarded") { continue } let percentage = UI.projects.visualScripting.utilities.nodeConfig.loadConfigProperty(childNode.payload, 'percentage') - if (percentage !== undefined && isNaN(percentage) && percentage > 0 !== true) { + if (percentage !== undefined && isNaN(percentage) !== true && percentage >= 0) { totalPercentage = totalPercentage + percentage } else { totalNodesWithoutPercentage++ diff --git a/Projects/Governance/UI/Function-Libraries/DelegationProgram.js b/Projects/Governance/UI/Function-Libraries/DelegationProgram.js index 160f563e6..2a132d6de 100644 --- a/Projects/Governance/UI/Function-Libraries/DelegationProgram.js +++ b/Projects/Governance/UI/Function-Libraries/DelegationProgram.js @@ -184,7 +184,7 @@ function newGovernanceFunctionLibraryDelegationProgram() { if (childNode === undefined) { continue } if (childNode.type === 'Tokens Bonus') { continue } let percentage = UI.projects.visualScripting.utilities.nodeConfig.loadConfigProperty(childNode.payload, 'percentage') - if (percentage !== undefined && isNaN(percentage) && percentage > 0 !== true) { + if (percentage !== undefined && isNaN(percentage) !== true && percentage >= 0) { totalPercentage = totalPercentage + percentage } else { totalNodesWithoutPercentage++ @@ -199,7 +199,7 @@ function newGovernanceFunctionLibraryDelegationProgram() { if (childNode === undefined) { continue } if (childNode.type === 'Tokens Bonus') { continue } let percentage = UI.projects.visualScripting.utilities.nodeConfig.loadConfigProperty(childNode.payload, 'percentage') - if (percentage !== undefined && isNaN(percentage) && percentage > 0 !== true) { + if (percentage !== undefined && isNaN(percentage) !== true && percentage >= 0) { totalPercentage = totalPercentage + percentage } else { totalNodesWithoutPercentage++ diff --git a/Projects/Governance/UI/Function-Libraries/TokenPower.js b/Projects/Governance/UI/Function-Libraries/TokenPower.js index 474e90f98..911507cd5 100644 --- a/Projects/Governance/UI/Function-Libraries/TokenPower.js +++ b/Projects/Governance/UI/Function-Libraries/TokenPower.js @@ -191,7 +191,7 @@ function newGovernanceFunctionLibraryTokenPower() { let percentage = getPercentage(childNode) - if (percentage !== undefined && isNaN(percentage) && percentage > 0 !== true) { + if (percentage !== undefined && isNaN(percentage) !== true && percentage >= 0) { totalPercentage = totalPercentage + percentage } else { totalNodesWithoutPercentage++ @@ -208,7 +208,7 @@ function newGovernanceFunctionLibraryTokenPower() { if (OPAQUE_NODES_TYPES.includes(childNode.type)) { continue } let percentage = getPercentage(childNode) - if (percentage !== undefined && isNaN(percentage) && percentage > 0 !== true) { + if (percentage !== undefined && isNaN(percentage) !== true && percentage >= 0) { totalPercentage = totalPercentage + percentage } else { totalNodesWithoutPercentage++ diff --git a/Projects/Governance/UI/Function-Libraries/VotingProgram.js b/Projects/Governance/UI/Function-Libraries/VotingProgram.js index cc633864c..e0a0e24ad 100644 --- a/Projects/Governance/UI/Function-Libraries/VotingProgram.js +++ b/Projects/Governance/UI/Function-Libraries/VotingProgram.js @@ -331,7 +331,7 @@ function newGovernanceFunctionLibraryVotingProgram() { if (childNode === undefined) { continue } if (childNode.type === 'Tokens Bonus') { continue } let percentage = UI.projects.visualScripting.utilities.nodeConfig.loadConfigProperty(childNode.payload, 'percentage') - if (percentage !== undefined && isNaN(percentage) && percentage > 0 !== true) { + if (percentage !== undefined && isNaN(percentage) !== true && percentage >= 0) { totalPercentage = totalPercentage + percentage } else { totalNodesWithoutPercentage++ @@ -346,7 +346,7 @@ function newGovernanceFunctionLibraryVotingProgram() { if (childNode === undefined) { continue } if (childNode.type === 'Tokens Bonus') { continue } let percentage = UI.projects.visualScripting.utilities.nodeConfig.loadConfigProperty(childNode.payload, 'percentage') - if (percentage !== undefined && isNaN(percentage) && percentage > 0 !== true) { + if (percentage !== undefined && isNaN(percentage) !== true && percentage >= 0) { totalPercentage = totalPercentage + percentage } else { totalNodesWithoutPercentage++ diff --git a/Projects/Governance/UI/Utilities/DecendentProgram.js b/Projects/Governance/UI/Utilities/DecendentProgram.js index 7c13159a1..db38958c6 100644 --- a/Projects/Governance/UI/Utilities/DecendentProgram.js +++ b/Projects/Governance/UI/Utilities/DecendentProgram.js @@ -283,7 +283,7 @@ function newGovernanceUtilitiesDecendentProgram() { for (let i = 0; i < node[usersArrayPropertyName].length; i++) { let childNode = node[usersArrayPropertyName][i] let percentage = UI.projects.visualScripting.utilities.nodeConfig.loadConfigProperty(childNode.payload, 'percentage') - if (percentage !== undefined && isNaN(percentage) && percentage > 0 !== true) { + if (percentage !== undefined && isNaN(percentage) !== true && percentage >= 0) { totalPercentage = totalPercentage + percentage } else { totalNodesWithoutPercentage++