From 9edbd6916940885ac7babd6452ff900330dd25e9 Mon Sep 17 00:00:00 2001 From: Luis Fernando Molina Date: Sun, 9 Aug 2020 18:04:21 +0200 Subject: [PATCH] Update TradingOrders.js --- LowFrequencyTrading/TradingOrders.js | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/LowFrequencyTrading/TradingOrders.js b/LowFrequencyTrading/TradingOrders.js index 530277879..a51039a9c 100644 --- a/LowFrequencyTrading/TradingOrders.js +++ b/LowFrequencyTrading/TradingOrders.js @@ -98,9 +98,9 @@ exports.newTradingOrders = function newTradingOrders(bot, logger, tradingEngineM for (let i = 0; i < orders.length; i++) { let tradingSystemOrder = orders[i] + tradingSystemValidations(tradingSystemOrder) let tradingEngineOrder = tradingEngineModule.getNodeById(tradingSystemOrder.referenceParent.id) - - definitionValidations(tradingSystemOrder, tradingEngineOrder) + tradingEngineValidations(tradingEngineOrder) switch (tradingEngineOrder.status.value) { case 'Not Open': { @@ -158,11 +158,13 @@ exports.newTradingOrders = function newTradingOrders(bot, logger, tradingEngineM } } - function definitionValidations(tradingSystemOrder, tradingEngineOrder) { + function tradingSystemValidations(tradingSystemOrder) { /* Trading System Validations */ if (tradingSystemOrder.config.percentageOfAlgorithmSize === undefined) { badDefinitionUnhandledException(undefined, 'tradingSystemOrder.config.percentageOfAlgorithmSize === undefined', tradingSystemOrder) } if (tradingSystemOrder.referenceParent === undefined) { badDefinitionUnhandledException(undefined, 'tradingSystemOrder.referenceParent === undefined', tradingSystemOrder) } + } + function tradingEngineValidations(tradingEngineOrder) { /* Trading Engine Order Validations */ if (tradingEngineOrder.serialNumber === undefined) { badDefinitionUnhandledException(undefined, 'tradingEngineOrder.serialNumber === undefined', tradingEngineOrder) } if (tradingEngineOrder.identifier === undefined) { badDefinitionUnhandledException(undefined, 'tradingEngineOrder.identifier === undefined', tradingEngineOrder) } @@ -185,7 +187,6 @@ exports.newTradingOrders = function newTradingOrders(bot, logger, tradingEngineM if (tradingEngineOrder.orderQuotedAsset.size === undefined) { badDefinitionUnhandledException(undefined, 'tradingEngineOrder.orderQuotedAsset.size === undefined', tradingEngineOrder) } if (tradingEngineOrder.orderQuotedAsset.sizeFilled === undefined) { badDefinitionUnhandledException(undefined, 'tradingEngineOrder.orderQuotedAsset.sizeFilled === undefined', tradingEngineOrder) } if (tradingEngineOrder.orderQuotedAsset.feesPaid === undefined) { badDefinitionUnhandledException(undefined, 'tradingEngineOrder.orderQuotedAsset.feesPaid === undefined', tradingEngineOrder) } - } async function tryToOpenOrder(tradingEngineStage, executionAlgorithm, tradingSystemOrder, tradingEngineOrder, situationName) {