From 87be5d20ec419fe7b5e78f279b810b1bd1d708ca Mon Sep 17 00:00:00 2001
From: Luis Fernando Molina <Luis-Fernando-Molina@users.noreply.github.com>
Date: Sun, 29 Apr 2018 23:49:55 +0200
Subject: [PATCH] File Cloud with Error Handling

---
 .vs/AAWeb/v15/.suo | Bin 66048 -> 66048 bytes
 Files/FileCloud.js | 239 ++++++++++++++++++++++++---------------------
 2 files changed, 127 insertions(+), 112 deletions(-)

diff --git a/.vs/AAWeb/v15/.suo b/.vs/AAWeb/v15/.suo
index 6532b15ed6a54442a33b4d86ebb08af3874b13f8..4e83290e80c73f37c0a51057d36a31cd975a6ec1 100644
GIT binary patch
delta 281
zcmZo@VQFY#*^tA;)^NNli}}IkBBo!=Y!l8@q=VROY!Zx<Hdo3il}(OYnmu{#D)z~9
zmTOF&J>@jlBoPJ%VFm^UE`~{4W&uThPFiR<IVxCfvcVLq$)4*BHy@qO#5}oo*<2<@
zhRGk6=%I*B{x_cwsBQDy1@4T(AX8lW8C|RlfUw%w)y>dw(}E|A%s}zU^A<=hTEa8g
zVOG#)&kgICSy_Q<88-jf9L6Z<0b)V{NLYIEo;6c8ZTikgNYUKM0c+Py=Gh~<dDkvm
f=0&@hCTlJ=-K=vUmWipBeX{%>oy`XhIoJaLT(n{h

delta 258
zcmZo@VQFY#*^tA;X27Aa=l%W7MNGe#*$nRFZ3nU0*d!P`H&@Cjl}$FCdV11~S(B#B
z2C+8HNMxQIw={e5+Ewh6>lSEC?p-#QiIHJ)!Bo}F`)4d-LYJHTZ$95<o<%npnI#w)
zCeK?WxoOc8MrLscd(je}$%<1vC$HbYxjA~nQf5}5ID_%z{k!tv#?RWZV{*e@9#$5h
zjMU^kYvyfc-1d!;kiyM-);KYO^ljd?%Z+)`Ue?KaOF1^P?EAwwS#Y|}W}S0am=_(f
F0|56OZ3_SZ

diff --git a/Files/FileCloud.js b/Files/FileCloud.js
index 0897951e9..1c48618b2 100644
--- a/Files/FileCloud.js
+++ b/Files/FileCloud.js
@@ -3,17 +3,24 @@ function newFileCloud() {
 
     const MODULE_NAME = "File Cloud";
     const INFO_LOG = false;
+    const ERROR_LOG = true;
     const logger = newDebugLog();
     logger.fileName = MODULE_NAME;
 
-    var fileCloud = {
+    /*
+
+    This is the module in the system that actually connects to the cloud storage and grabs from there the needed files. 
+
+    */
+
+    var thisObject = {
         getFile: getFile,
         initialize: initialize
     };
 
     let blobService;
 
-    return fileCloud;
+    return thisObject;
 
     function initialize(pBot) {
 
@@ -26,130 +33,138 @@ function newFileCloud() {
 
     function getFile(pDevTeam, pBot, pSet, pExchange, pMarket, pPeriodName, pDatetime, pSequence, callBackFunction) {
 
-        if (INFO_LOG === true) { logger.write("[INFO] getFile -> Entering function."); }
-        if (INFO_LOG === true) { logger.write("[INFO] getFile -> key = " + pDevTeam.codeName + "-" + pBot.codeName + "-" + pSet.filePath + "-" + pSet.fileName); }
-
-        let fileName = pSet.fileName;
-        let filePath = pSet.filePath;
-
-        if (fileName === undefined) {
-
-            logger.write("[ERROR] getFile -> Inconsistant data. Check the following: ");
-            logger.write("[ERROR] getFile -> pDevTeam = " + JSON.stringify(pDevTeam));
-            logger.write("[ERROR] getFile -> pBot = " + JSON.stringify(pBot));
-            logger.write("[ERROR] getFile -> pSet = " + JSON.stringify(pSet));
-            logger.write("[ERROR] getFile -> pExchange = " + JSON.stringify(pExchange));
-            logger.write("[ERROR] getFile -> pMarket = " + JSON.stringify(pMarket));
-            logger.write("[ERROR] getFile -> pPeriodName = " + JSON.stringify(pPeriodName));
-
-            throw ("Inconsistant data received.");
-        }
-
-        if (pMarket !== undefined) {
-
-            fileName = fileName.replace("@AssetA", pMarket.assetA);
-            fileName = fileName.replace("@AssetB", pMarket.assetB);
-        }
-
-        if (pDevTeam !== undefined) {
-
-            filePath = filePath.replace("@DevTeam", pDevTeam.codeName);
-        }
-
-        if (pBot !== undefined) {
-
-            filePath = filePath.replace("@Bot", pBot.codeName);
-        }
-
-        if (pExchange !== undefined) {
-
-            filePath = filePath.replace("@Exchange", pExchange.name);
-        }
-
-        filePath = filePath.replace("@Period", pPeriodName);
-
-        if (pDatetime !== undefined) {
-
-            filePath = filePath.replace("@Year", pDatetime.getUTCFullYear());
-            filePath = filePath.replace("@Month", pad(pDatetime.getUTCMonth() + 1, 2));
-            filePath = filePath.replace("@Day", pad(pDatetime.getUTCDate(), 2));
-            filePath = filePath.replace("@Hour", pad(pDatetime.getUTCHours(), 2));
-            filePath = filePath.replace("@Minute", pad(pDatetime.getUTCMinutes(), 2));
-
-        }
-
-        if (pSequence !== undefined) {
-
-            fileName = fileName.replace("@Sequence", pSequence); 
-        }
-
-        if (INFO_LOG === true) { logger.write("[INFO] getFile -> filePath = " + filePath); }
-        if (INFO_LOG === true) { logger.write("[INFO] getFile -> fileName = " + fileName); }
-
         try {
 
+            if (INFO_LOG === true) { logger.write("[INFO] getFile -> Entering function."); }
+            if (INFO_LOG === true) { logger.write("[INFO] getFile -> key = " + pDevTeam.codeName + "-" + pBot.codeName + "-" + pSet.filePath + "-" + pSet.fileName); }
+
+            let fileName = pSet.fileName;
+            let filePath = pSet.filePath;
+
+            if (fileName === undefined) {
+
+                logger.write("[ERROR] getFile -> Inconsistant data. Check the following: ");
+                logger.write("[ERROR] getFile -> pDevTeam = " + JSON.stringify(pDevTeam));
+                logger.write("[ERROR] getFile -> pBot = " + JSON.stringify(pBot));
+                logger.write("[ERROR] getFile -> pSet = " + JSON.stringify(pSet));
+                logger.write("[ERROR] getFile -> pExchange = " + JSON.stringify(pExchange));
+                logger.write("[ERROR] getFile -> pMarket = " + JSON.stringify(pMarket));
+                logger.write("[ERROR] getFile -> pPeriodName = " + JSON.stringify(pPeriodName));
+
+                throw ("Inconsistant data received.");
+            }
+
+            if (pMarket !== undefined) {
+
+                fileName = fileName.replace("@AssetA", pMarket.assetA);
+                fileName = fileName.replace("@AssetB", pMarket.assetB);
+            }
+
+            if (pDevTeam !== undefined) {
+
+                filePath = filePath.replace("@DevTeam", pDevTeam.codeName);
+            }
+
+            if (pBot !== undefined) {
+
+                filePath = filePath.replace("@Bot", pBot.codeName);
+            }
+
+            if (pExchange !== undefined) {
+
+                filePath = filePath.replace("@Exchange", pExchange.name);
+            }
+
+            filePath = filePath.replace("@Period", pPeriodName);
+
+            if (pDatetime !== undefined) {
+
+                filePath = filePath.replace("@Year", pDatetime.getUTCFullYear());
+                filePath = filePath.replace("@Month", pad(pDatetime.getUTCMonth() + 1, 2));
+                filePath = filePath.replace("@Day", pad(pDatetime.getUTCDate(), 2));
+                filePath = filePath.replace("@Hour", pad(pDatetime.getUTCHours(), 2));
+                filePath = filePath.replace("@Minute", pad(pDatetime.getUTCMinutes(), 2));
+
+            }
+
+            if (pSequence !== undefined) {
+
+                fileName = fileName.replace("@Sequence", pSequence);
+            }
+
+            if (INFO_LOG === true) { logger.write("[INFO] getFile -> filePath = " + filePath); }
+            if (INFO_LOG === true) { logger.write("[INFO] getFile -> fileName = " + fileName); }
+
             blobService.getBlobToText('data', filePath + "/" + fileName, onFileReceived);
 
-        } catch (err) {
-
-            if (INFO_LOG === true) { logger.write("[ERROR] getFile -> err = " + err); }
-
-        }
-
-        function onFileReceived(err, text, response) {
-
-            if (INFO_LOG === true) { logger.write("[INFO] getFile -> onFileReceived -> Entering function."); }
-            if (INFO_LOG === true) { logger.write("[INFO] getFile -> onFileReceived -> filePath = " + filePath); }
-            if (INFO_LOG === true) { logger.write("[INFO] getFile -> onFileReceived -> fileName = " + fileName); }
-
-            let data;
-
-            if (err) {
-
-                if (err.code === "BlobNotFound") {
-
-                    let customErr = {
-                        result: GLOBAL.CUSTOM_FAIL_RESPONSE.result,
-                        message: "File does not exist."
-                    };
-
-                    if (INFO_LOG === true) { logger.write("[WARN] getFile -> onFileReceived -> customErr.message = " + customErr.message); }
-
-                    callBackFunction(customErr);
-                    return;
-                }
-
-                if (INFO_LOG === true) { logger.write("[ERROR] getFile -> onFileReceived -> Unexpected Error Ocurred."); }
-                if (INFO_LOG === true) { logger.write("[ERROR] getFile -> onFileReceived -> err = " + err); }
-                callBackFunction(GLOBAL.DEFAULT_FAIL_RESPONSE);
-                return;
-
-            } else {
+            function onFileReceived(err, text, response) {
 
                 try {
 
-                    data = JSON.parse(text);
+                    if (INFO_LOG === true) { logger.write("[INFO] getFile -> onFileReceived -> Entering function."); }
+                    if (INFO_LOG === true) { logger.write("[INFO] getFile -> onFileReceived -> filePath = " + filePath); }
+                    if (INFO_LOG === true) { logger.write("[INFO] getFile -> onFileReceived -> fileName = " + fileName); }
 
-                    if (INFO_LOG === true) { logger.write("[INFO] getFile -> onFileReceived -> Data received is valid JSON."); }
+                    let data;
 
-                    callBackFunction(GLOBAL.DEFAULT_OK_RESPONSE, data);
-                    return;
+                    if (err) {
+
+                        if (err.code === "BlobNotFound") {
+
+                            let customErr = {
+                                result: GLOBAL.CUSTOM_FAIL_RESPONSE.result,
+                                message: "File does not exist."
+                            };
+
+                            if (INFO_LOG === true) { logger.write("[WARN] getFile -> onFileReceived -> customErr.message = " + customErr.message); }
+
+                            callBackFunction(customErr);
+                            return;
+                        }
+
+                        if (INFO_LOG === true) { logger.write("[ERROR] getFile -> onFileReceived -> Unexpected Error Ocurred."); }
+                        if (INFO_LOG === true) { logger.write("[ERROR] getFile -> onFileReceived -> err = " + err); }
+                        callBackFunction(GLOBAL.DEFAULT_FAIL_RESPONSE);
+                        return;
+
+                    } else {
+
+                        try {
+
+                            data = JSON.parse(text);
+
+                            if (INFO_LOG === true) { logger.write("[INFO] getFile -> onFileReceived -> Data received is valid JSON."); }
+
+                            callBackFunction(GLOBAL.DEFAULT_OK_RESPONSE, data);
+                            return;
+
+                        } catch (err) {
+
+                            if (INFO_LOG === true) { logger.write("[WARN] getFile -> onFileReceived -> err = " + err); }
+
+                            let customErr = {
+                                result: GLOBAL.CUSTOM_OK_RESPONSE.result,
+                                message: "Data not in JSON Format."
+                            };
+
+                            if (INFO_LOG === true) { logger.write("[WARN] getFile -> onFileReceived -> customErr.message = " + customErr.message); }
+
+                            callBackFunction(customErr, text);
+                            return;
+                        }
+                    }
 
                 } catch (err) {
 
-                    if (INFO_LOG === true) { logger.write("[WARN] getFile -> onFileReceived -> err = " + err); }
-
-                    let customErr = {
-                        result: GLOBAL.CUSTOM_OK_RESPONSE.result,
-                        message: "Data not in JSON Format."
-                    };
-
-                    if (INFO_LOG === true) { logger.write("[WARN] getFile -> onFileReceived -> customErr.message = " + customErr.message); }
-
-                    callBackFunction(customErr, text);
-                    return;
+                    if (ERROR_LOG === true) { logger.write("[ERROR] getFile -> onFileReceived -> err = " + err); }
+                    callBackFunction(GLOBAL.CUSTOM_FAIL_RESPONSE);
                 }
             }
+
+        } catch (err) {
+
+            if (ERROR_LOG === true) { logger.write("[ERROR] getFile -> err = " + err); }
+            callBackFunction(GLOBAL.CUSTOM_FAIL_RESPONSE);
         }
     }
 }
\ No newline at end of file