From 7466493d442236cd9dca8c18280fb453a1be07fd Mon Sep 17 00:00:00 2001 From: Luis Fernando Molina Date: Mon, 1 Apr 2019 11:08:51 +0200 Subject: [PATCH] Comments Updated --- Historic-Trades/User.Bot.js | 2 +- Hole-Fixing/User.Bot.js | 2 +- Live-Trades/User.Bot.js | 4 ++-- this.bot.config.json | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Historic-Trades/User.Bot.js b/Historic-Trades/User.Bot.js index 90688dbcc..a11ffd18d 100644 --- a/Historic-Trades/User.Bot.js +++ b/Historic-Trades/User.Bot.js @@ -546,7 +546,7 @@ This process complements the Live Trades process and write historical trades fil let currentProcessMinute = Math.trunc(currentDate.valueOf() / 1000 / 60); let firstProcessMinute = currentProcessMinute; - /* We will iterate through all the records received from the exchange. We know Poloniex sends the older records first, so this is going to be going back in time as we advance. */ + /* We will iterate through all the records received from the exchange. We expect the exchange API to return the records ordered by ID DESC so we change it to ASC. So this is going to be going back in time as we advance. */ for (let i = 0; i < tradesRequested.length; i++) { diff --git a/Hole-Fixing/User.Bot.js b/Hole-Fixing/User.Bot.js index 5d87a4d97..fab1d119c 100644 --- a/Hole-Fixing/User.Bot.js +++ b/Hole-Fixing/User.Bot.js @@ -909,7 +909,7 @@ let currentProcessMinute = Math.trunc(holeFinalDatetime.valueOf() / 1000 / 60); // Number of minutes since the begining of time, where the process is pointing to. let holeStartsMinute = Math.trunc(holeInitialDatetime.valueOf() / 1000 / 60); // Number of minutes since the begining of time, where the hole started. - /* We will iterate through all the records received from the exchange. We know Poloniex sends the older records first, so this is going to be going back in time as we advance. */ + /* We will iterate through all the records received from the exchange. // We expect the exchange API to return the records ordered by ID DESC so we change it to ASC. So this is going to be going back in time as we advance. */ for (let i = 0; i < tradesRequested.length; i++) { diff --git a/Live-Trades/User.Bot.js b/Live-Trades/User.Bot.js index c4a53f5a8..3a215b321 100644 --- a/Live-Trades/User.Bot.js +++ b/Live-Trades/User.Bot.js @@ -200,7 +200,7 @@ for (i = 0; i < exchangeResponse.length; i++) { - let record = exchangeResponse[exchangeResponse.length - 1 - i]; // In Poloniex the order of the records is by date DESC so we change it to ASC + let record = exchangeResponse[exchangeResponse.length - 1 - i]; // We expect the exchange API to return the records ordered by ID DESC so we change it to ASC const trade = { tradeIdAtExchange: record.tradeID, @@ -267,7 +267,7 @@ for (i = 0; i < exchangeResponse.length; i++) { - let record = exchangeResponse[exchangeResponse.length - 1 - i]; // In Poloniex the order of the records is by date DESC so we change it to ASC + let record = exchangeResponse[exchangeResponse.length - 1 - i]; // We expect the exchange API to return the records ordered by ID DESC so we change it to ASC const trade = { tradeIdAtExchange: record.tradeID, diff --git a/this.bot.config.json b/this.bot.config.json index 9441fede0..ab534a661 100644 --- a/this.bot.config.json +++ b/this.bot.config.json @@ -105,8 +105,8 @@ "startMode": { "allMonths": { "run": "true", - "minYear": "2018", - "maxYear": "2019" + "minYear": "2019", + "maxYear": "2021" }, "oneMonth": { "run": "false",