From 69ef7c217fd5a94b94fcf4875ad0e4e702ba5d5c Mon Sep 17 00:00:00 2001
From: Luis Fernando Molina <Luis-Fernando-Molina@users.noreply.github.com>
Date: Wed, 2 May 2018 20:48:00 +0200
Subject: [PATCH] Rounding BUG corrected

---
 .vs/AACloud/v15/.suo | Bin 100864 -> 103936 bytes
 Assistant.js         |  21 +++++++++++++++++----
 2 files changed, 17 insertions(+), 4 deletions(-)

diff --git a/.vs/AACloud/v15/.suo b/.vs/AACloud/v15/.suo
index 8e883487b15302f051b255ea22255e161d9498f7..c975857f2d68d341ea57775429c2d836a3178485 100644
GIT binary patch
delta 2270
zcmciCeNYs27zgls_HK_mJ<mHqNrYI!7mOFtF;m8o1J7W@4A88si8BecVM=_LG<Bva
z|6m;1M_nwVYaP!t6uV_S$EoSiB63vlrI=)<PG@YWY{r_Vu<@nuPYy$-vHHW7`S3ja
z_P4*6XMfAaZPtwq)<cz&>>51OH-oFBb2g{RWO@wPUzoz#(m-BguA^tzZQ-P+(3}B@
zFb;~q2I=rBH(PS)O(r>>_V93d1ii+O$f<cLxc4l~1uNXbRfd=a&%+#e8btd%#D!1}
zNl*bRc&D7|U5cy<mceqkiQX#_SHW6X15-c&G1B^IoQSvqHi0Tt%3B*^$jepMbL=&L
zq}p6Go87i#8qecxsbt|N@q0e6wH4&OjR$5x3`~MNu){;(gKWrwWVnF|Mb*T_9>h%8
zjY7m`#v=Owo`6yCD2Reo!vuH-WLO8m+LAGpRa+8Ivv`wz5zREdx6gOk$&GswMBhgY
zH5n@t=8$DjpEl#y5$7F7>)gqtK0KX|o5#~9=ro(`x7XCS=fHL{nJjn|mvL($Nx`hv
z(MD_9WYXt3^?*fRY}40B`ZB9plSUektr^3`10Hx$LHAuC>RAu(f*;-k9acjCL<z*T
z5BdAh0Q*54sDp3-8sQLl;X^P$ywAOSswSB}tu0Blw4jNLH(ya*ilJ1Glx+Qrz$-G^
z>?CFqFQ~UP#)|bdPBmkC&$jQrv#y4;(jrRGmX_iKcuE|`OIw^~X>^=XUHgVbt@qkQ
zRSNDJt-gT_r7lAHVM*U51%ri>QTWyo((<08WFuL>W~bFWykWI0c6WrgH!RHDi!2Py
za14&aXCPMkc{H{negQXY7j&xig%<H8{k4Po8VVj<OElc5Zp6CkPyl~~f=!BKC`Yr0
z(I75qKR`uH9jEx@nHDNCsACE7^>eP?bk&!4(yL$fq!_Q~iNde9MYH`Es*zP)WcHuW
z;a@ttqV1<6D(8IT;*o7}nk${Q5V5;0oqL*RjXK;uB&YINySpjh<R3XR=`7ZM`*h+|
z^&TtJTuzZjjQzWwqIdN0nZy@UYFcS}*(i(bAwIO+d1oq}kA6G#eoVz>kyo@6=`@KW
z7vi)dK1vvL0xK8)&qS=?l(zUjyS{hV&fNcLiM#RnizSMfdG96m>w4doSir%{Q+e0r
za?bBaU{9yQzVlYYb15v7Piu~)eBRcQ!TuKIU-7wz7|lQDN@|zFv$_?-(-kIl7*76g
z`1XE~^gkpmC6Okw(xs@^JnEIo;7=an@bzqN+~C%79W+>5KakRFTgaP}ji0^Y$z<Lk
zlSglnG>=S$w1Y2pm+{pbF4k_O8If*<^i~Vkwv1z++a2;uqi~FVQVI+piD_uO5r2A$
zL{6imz0n+SkaYM#y5i`6QaaD{J0AUO-~axi=xbbpn8Yca`#4K-adF20Q8(g1nG=6F
z`V=!FN2_tn%m=$C{O9d&zI)rD$W&770Vi3+J_E&w4zg<b<&+Rgm`~rCdD({8P;4CS
zBzGy+*n2HTK27_0D0xHVqg$jcNTkeAW+I&>_m91u5PuhW$TgF$QlJ78ynqQFCkiYf
zxzEV@osma}L&#@{k*5bXVkQ4Lt~pSSaeKy$;ie0|kZ%?FDX^3z?NSBhX#NV?8alC=
KCQ;yZvi=EI!lGgT

delta 1486
zcmbu;e@s<X00(fs=iU2w4<Enerzmm(MY5o$BSQScOFWU86PQRvO$i;j<{xN?4<x|a
zY%6Q=j&jkg=xVPrP<)qhUDNf{t+CeBl4h$m-`d)0Ypp+6n+>V&EtsxV|8%y`J@=k_
ze%$XpJN+Z>{v+<O-9pv-{72&C9&tkk;xB}h6g)0d6`9)<7Z>*cEujbLQS#9J)FCe^
z>u^v)&B9A^k-8Y2@*%ab>IuGUBsXoR-&yimm(n)cLXVNt{v_)iw3BkFjoRfgwJ<Qt
zw|n@sm!2by_E8yiQIOWq0di(~ey;9i-ADT=BzCL*hA#&g%zeX?$d($C!?pR+FBZsP
z{17(ER8JmO%T=C2q{*$k*2yl<hN@%is89x#Qx$osfa1wdm6S&<ltj*F=&VcV9sZWI
zk~?hqfKQufIjtp?x~YfWp!r`D8E9C6hX)$6&@2ynpTTD9M{jeAyy9AgbJo6`El>n|
z&wYHnHNAMsXH7O%AhfdD3n$yXuW_D3>flLbyAxx6n0g&-khc%iDNc&{X4%nmO;*2p
zF;Y5NWK9-Vz-&q~PbuaukJ%>7z3x!IW@+s)$o{+ntDw6;c$}<G=J^?{j>Csx_9lgb
z#W*VO3$EyMHgJ$V3>qShj+3*2C+JOji{7STayHDQlN2Ur1*bS$_CAf!Y5I`P&?udy
zF$&OoWRbJ(I6v%KFjp=c{dS<eBJx_$C0bIf?tw!}WLy)LHWY(7EX)%kbf#9>z(IFo
z435CkCSowEo<g3LXWsUrMlKrJufFT7A&-viNd1_1QMyEz>59xBy*1FD9U1EaxXigj
zN@%#&sy+V|r#c=(XfWV${<d>~{<hFZ{!A>e8?tfM6`JzdzNKjNSuL?sko8juvi_z|
z>fdOxWy)>qe#BH+Hlx{kIWD`5>&Zwl)+M7@UY%KOL=)hb?X&f=csf0DN9XXF8Y4$R
zr4^mkVg90wBMPa{=;p6N_RnM*rxlb-ZCV>tp$}G~%#JD0VE!fyPXa1<JUq6ZfT(JI
zBEl&U=A;r%hcGT=AmCgQ?9GjcsFBYg<igH0JAE65kh-1$|0+e%t-Q%LE^bFaii}Jv
z>*^XYpVWA|6(x2_E4~0;oLGvVe2IVd<_M=QHS(9^^Ux3F@{yZ4|2O~1=&XymoBkoN
z4$W&MC!)wMO2^l@H`@|Kkm#JJx$=rI@^>Q5)_M?gg*QTk>!E}<F?@7w`hSJ5ma$&V
z)>?6kQNztp{$<whV2c*aBD{<9wsGFp?>X!R#Nxx9T<uwiiP!O|V))yz%>MahEQB$>
M5_h{O;SiKR0ER54ivR!s

diff --git a/Assistant.js b/Assistant.js
index 8d4d9f35e..85c0fdf3a 100644
--- a/Assistant.js
+++ b/Assistant.js
@@ -611,12 +611,17 @@
 
                             }
 
+                            sumAssetB = Number(sumAssetB.toFixed(8));
+
                             if (
                                 position.amountB !== sumAssetB
                             ) {
+                                logger.write("[ERROR] ordersExecutionCheck -> loopBody -> position.amountB = " + position.amountB);
+                                logger.write("[ERROR] ordersExecutionCheck -> loopBody -> sumAssetB = " + sumAssetB);
+
                                 logger.write("[ERROR] ordersExecutionCheck -> loopBody -> confirmOrderWasExecuted -> Cannot be confirmed that the order was executed. It must be manually cancelled by the user or cancelled by the exchange itself.");
                                 logger.write("[HINT] ordersExecutionCheck -> loopBody -> confirmOrderWasExecuted -> If the process was abruptally cancelled and then restarted, it is possible that now is not sincronized with the exchange.");
-                                logger.write("[HINT] ordersExecutionCheck -> loopBody -> confirmOrderWasExecuted -> In any case, to continue, you must delete the Status Report file so as to start over. Also, you must manually delete the orders at the exchange.");
+                                logger.write("[HINT] ordersExecutionCheck -> loopBody -> confirmOrderWasExecuted -> In any case, to continue, you must manually delete the orders at the exchange.");
                                 callBack(global.DEFAULT_FAIL_RESPONSE);
                                 return;
                             }
@@ -676,6 +681,10 @@
                                 sumAssetA = sumAssetA + pTrades[k].amountA;
                                 sumAssetB = sumAssetB + pTrades[k].amountB;
 
+                                /* We add the fees */
+
+                                sumAssetA = sumAssetA - Number(pTrades[k].fee);
+
                             }
 
                             /* To this we add the current position amounts. */
@@ -683,14 +692,18 @@
                             sumAssetA = sumAssetA + exchangePosition.amountA;
                             sumAssetB = sumAssetB + exchangePosition.amountB;
 
-                            /* And finally we add the fees */
-
-                            sumAssetA = sumAssetA + exchangePosition.fee;
+                            sumAssetA = Number(sumAssetA.toFixed(8));
+                            sumAssetB = Number(sumAssetB.toFixed(8));
 
                             if (
                                 position.amountA !== sumAssetA ||
                                 position.amountB !== sumAssetB
                             ) {
+                                logger.write("[ERROR] ordersExecutionCheck -> loopBody -> confirmOrderWasPartiallyExecuted -> position.amountA = " + position.amountA);
+                                logger.write("[ERROR] ordersExecutionCheck -> loopBody -> confirmOrderWasPartiallyExecuted -> sumAssetA = " + sumAssetA);
+                                logger.write("[ERROR] ordersExecutionCheck -> loopBody -> confirmOrderWasPartiallyExecuted -> position.amountB = " + position.amountB);
+                                logger.write("[ERROR] ordersExecutionCheck -> loopBody -> confirmOrderWasPartiallyExecuted -> sumAssetB = " + sumAssetB);
+
                                 logger.write("[ERROR] ordersExecutionCheck -> loopBody -> confirmOrderWasPartiallyExecuted -> Cannot be confirmed that a partially execution was done well.");
                                 callBack(global.DEFAULT_FAIL_RESPONSE);
                                 return;