diff --git a/README.md b/README.md index 5650f6db0..76a35b66e 100644 --- a/README.md +++ b/README.md @@ -1,67 +1,5 @@ -# ModuleUsers -## Component Hierarchy - -App.js -| -|- NavBar -| | -| |- LoggedInUser -| | | -| | |- LoggedInUserMenu -| | | | -| | | |- Menu 1 - Link to User -| | | | -| | | |- Menu 2 - Link to Logout -| | -|- Switch -| | -| |- User -| | | -| | |- UserTabs -| | | | -| | | |- Tab 1 - ProfileSheet -| | | | -| | | |- Tab 2 - ManageImages -| | -| |- Browse -| | | -| | |- UserLists -| | -| |- Search -| | -| |- About -| | -| |- Contact -| | -| |- Logout -| | -| |- Callback -| | -|- Footer - - - -## Known Improvements - -1. Remove the relationship to users, since it is not needed. - -const RoleType = new GraphQLObjectType({ - name: 'Role', - fields: () => ({ - id: { type: GraphQLID}, - name: {type: GraphQLString}, - users: { - type: new GraphQLList(UserType), - resolve(parent, args) { - return User.find({roleId: parent.id}); - } - } - }) -}); - -2. Roles should be an Enum Type. - -Since roles just have a name field, I think we should use the ENUM type... https://graphql.org/learn/schema/#enumeration-types -They would just be resolved in Mongoose/MongoDB as strings and we would validate specifcially to those strings. -Unless there's going to be many types of roles in the future. +![alt text](https://github.com/AdvancedAlgos/UsersModule/blob/master/image.png?raw=true "Screenshot") + + +