From 2c171b780ef2ad9678ff6e40103d9654fbc6bc79 Mon Sep 17 00:00:00 2001 From: Luis Fernando Molina Date: Wed, 3 Apr 2019 17:09:53 +0200 Subject: [PATCH] Protecting the bot against a bad response from the ExchangeAPI --- Hole-Fixing/User.Bot.js | 13 +++++++++++++ Live-Trades/User.Bot.js | 13 +++++++++++++ 2 files changed, 26 insertions(+) diff --git a/Hole-Fixing/User.Bot.js b/Hole-Fixing/User.Bot.js index 1d28ea08a..fde452669 100644 --- a/Hole-Fixing/User.Bot.js +++ b/Hole-Fixing/User.Bot.js @@ -846,6 +846,19 @@ if (FULL_LOG === true) { logger.write(MODULE_NAME, "[INFO] start -> onExchangeCallReturned -> Entering function."); } + if (err.result !== global.DEFAULT_OK_RESPONSE.result) { + logger.write(MODULE_NAME, "[WARN] start -> tradesReadyToBeSaved -> Somethinig is wrong with the Exchange Response. "); + logger.write(MODULE_NAME, "[WARN] start -> tradesReadyToBeSaved -> err.message = " + err.message); + callBackFunction(global.DEFAULT_RETRY_RESPONSE); + return; + } + + if (exchangeResponse === undefined) { + logger.write(MODULE_NAME, "[WARN] start -> tradesReadyToBeSaved -> exchangeResponse is UNDEFINED. "); + callBackFunction(global.DEFAULT_RETRY_RESPONSE); + return; + } + if (FULL_LOG === true) { let exchangeResponseTime = new Date(); diff --git a/Live-Trades/User.Bot.js b/Live-Trades/User.Bot.js index 3a215b321..1012de4c4 100644 --- a/Live-Trades/User.Bot.js +++ b/Live-Trades/User.Bot.js @@ -160,6 +160,19 @@ if (FULL_LOG === true) { logger.write(MODULE_NAME, "[INFO] start -> onExchangeCallReturned -> Entering function."); } + if (err.result !== global.DEFAULT_OK_RESPONSE.result) { + logger.write(MODULE_NAME, "[WARN] start -> tradesReadyToBeSaved -> Somethinig is wrong with the Exchange Response. "); + logger.write(MODULE_NAME, "[WARN] start -> tradesReadyToBeSaved -> err.message = " + err.message); + callBackFunction(global.DEFAULT_RETRY_RESPONSE); + return; + } + + if (exchangeResponse === undefined) { + logger.write(MODULE_NAME, "[WARN] start -> tradesReadyToBeSaved -> exchangeResponse is UNDEFINED. "); + callBackFunction(global.DEFAULT_RETRY_RESPONSE); + return; + } + if (FULL_LOG === true) { let exchangeResponseTime = new Date();