From 240d549fc794d5c3adb63cde22ff27105b7d11f0 Mon Sep 17 00:00:00 2001 From: Luis Fernando Molina Date: Mon, 1 Feb 2021 09:41:15 +0100 Subject: [PATCH] Dependency Fileter Refactoring --- .../UI/Function-Libraries/DependenciesFilter.js | 12 ++++++++---- .../Function-Libraries/LearningSessionFunctions.js | 2 +- .../UI/Function-Libraries/TradingSessionFunctions.js | 2 +- 3 files changed, 10 insertions(+), 6 deletions(-) diff --git a/Projects/Superalgos/UI/Function-Libraries/DependenciesFilter.js b/Projects/Superalgos/UI/Function-Libraries/DependenciesFilter.js index d91490ba0..47e5ad594 100644 --- a/Projects/Superalgos/UI/Function-Libraries/DependenciesFilter.js +++ b/Projects/Superalgos/UI/Function-Libraries/DependenciesFilter.js @@ -1,20 +1,24 @@ function newSuperalgosFunctionLibraryDependenciesFilter() { /* + A Dependency Filter is list of Indicators a Strategy depends + on, that is later used to filter out all the other indicators + the Trading Bot depends on. + The function will scen a node branch, most likely a Trading System, looking into the code property of each node. It will analyze it's content and try to make a list of all indicators mentioned at the code text and at which time frames they are mentioned. - It is important to note that all node that are not of the type - Javascript Code are going to be filtered out. + It is important to note that all nodes that are not of the type + Javascript Code or Formula are going to be ignored. */ thisObject = { - createFilter: createFilter + createDependencyFilter: createDependencyFilter } return thisObject - function createFilter(node) { + function createDependencyFilter(node) { let filters = new Map() recursiveFilter(node) diff --git a/Projects/Superalgos/UI/Function-Libraries/LearningSessionFunctions.js b/Projects/Superalgos/UI/Function-Libraries/LearningSessionFunctions.js index e56e35759..a9ffb2271 100644 --- a/Projects/Superalgos/UI/Function-Libraries/LearningSessionFunctions.js +++ b/Projects/Superalgos/UI/Function-Libraries/LearningSessionFunctions.js @@ -122,7 +122,7 @@ function newSuperalgosFunctionLibraryLearningSessionFunctions() { let session = UI.projects.superalgos.functionLibraries.protocolNode.getProtocolNode(node, false, true, true, false, false, lightingPath) - let dependencyFilter = UI.projects.superalgos.functionLibraries.dependenciesFilter.createFilter(node.tradingSystemReference.payload.referenceParent) + let dependencyFilter = UI.projects.superalgos.functionLibraries.dependenciesFilter.createDependencyFilter(node.tradingSystemReference.payload.referenceParent) /* Raise event to run the session */ let event = { diff --git a/Projects/Superalgos/UI/Function-Libraries/TradingSessionFunctions.js b/Projects/Superalgos/UI/Function-Libraries/TradingSessionFunctions.js index b591b9c1c..2b5733ba2 100644 --- a/Projects/Superalgos/UI/Function-Libraries/TradingSessionFunctions.js +++ b/Projects/Superalgos/UI/Function-Libraries/TradingSessionFunctions.js @@ -123,7 +123,7 @@ function newSuperalgosFunctionLibraryTradingSessionFunctions() { let session = UI.projects.superalgos.functionLibraries.protocolNode.getProtocolNode(node, false, true, true, false, false, lightingPath) - let dependencyFilter = UI.projects.superalgos.functionLibraries.dependenciesFilter.createFilter(node.tradingSystemReference.payload.referenceParent) + let dependencyFilter = UI.projects.superalgos.functionLibraries.dependenciesFilter.createDependencyFilter(node.tradingSystemReference.payload.referenceParent) /* Raise event to run the session */ let event = {