From 2312154988dbbf64cd47de20e36fe9f878349ff7 Mon Sep 17 00:00:00 2001
From: Luis Fernando Molina <Luis-Fernando-Molina@users.noreply.github.com>
Date: Sat, 3 Mar 2018 10:03:45 +0100
Subject: [PATCH] Logging Improved

---
 .vs/AACloudPlatform/v15/.suo | Bin 51712 -> 60928 bytes
 Azure File Storage.js        |  49 +++++++++++++++++++++++------------
 2 files changed, 33 insertions(+), 16 deletions(-)

diff --git a/.vs/AACloudPlatform/v15/.suo b/.vs/AACloudPlatform/v15/.suo
index 62f1c3be116e74b908921ff7b3426e241bcf04e7..7dd31286cecabc303319ef8cc1fab1dc6c94996a 100644
GIT binary patch
delta 3908
zcmeH~eNdFu9><^a><bG5vdYV12rD400xJ}PDCz@jOxLLhMInO_b3+M2UKYB0F;;t{
znr`m%v$@?~*X?zhOxVZFaTa_O->55g&8hxq8v3i6X`FK651Ep_XWex`ZZ+Mj_m4aG
z?0lYc&hK|#e$Vgx&Uwzd_GnyRXm;n$7lmMo5rha7HQ@5(<Rq7B2JSG6QD6O#GwS<<
zl|mp@kW+NBVj34GSsjgQ(paXuGLs~&DQX$?>j3&rR=Fz^isDfz3<|hVLOEwjJ!MLn
z>*oaP`R>Y_mX=IWYEdo*=~HAy!7?|Mr&XwDkxp0Ga2HCIU@b@hbHRGB0aSy#!O!Ti
z5&1o!7Sw@zK?B$X_^6wa-v=52pCOdm@WN5;5O#o0Q17l>B8$z@(i=JD+)+u8O>tC(
zAqoO3AkS$t<%*H?kfw)wFD$b+65?2307eiE!U6ZiY!C<1fDT}RghVh8@FBTDw;-Pd
zmI4#thR;Wy3>JWp(Wxje1X56zf!xA}=M5I2vKV9smDF!A-5PQoZ%_cm@}QE}d0K(`
z%Ajm@FfT)XQ?Sh2Y;jkvqfOztd3Ffz2TeicHssvY2aq>|7Vscw1>1qcT{)L_hilzc
z7CFN6r)&lTK^EZMa*$iW5|9h>z|G(mkPnuE0#FE+fg-RRtWaK#NMJW$#OO}_1(+Q_
zo1D>3_AQM^_p)!uF}pYNYlwOL@+ALCGvhj~2z4+#47xxc<x<LD7`ulYb9;3>RAcE<
zPK7pXN;|fN9M(}P%Nq2>)-rlDHpa$dnLCKbay{4t8bBzPxsJovg2y#qk89V0`r}L{
z-iXJx19X9I@DNbO;`WH_Gjf=E^*sI;MAC$5g4vbv#94Y@szI}C7}De51ULy!fzx0F
zd<Z@Q{{UyeC^!rFY$PqL;qRcly|6|rXaC4*XgvE7QH~&IPM;#?USvAHbG0-4qFgEr
z6TQWvH(&HgsUmsPQVkeyl5d}@E?tDxKSb{GCFChjqMhZdk()V8m{BYCJ}i27X=Q6C
z+oCwEPqY7?duc4r?5px<SQzcCu9pi^mDJlVGsRpm#%SlV1SO&7TaCQDbH)Pb`3Cz=
zR3_^5dha~ZyG8USiPYB+OXr(2X#0>}J9Ysserd!^HC^-A>vW_sj&?WbskR|Q-g-y&
z^5$b78xNEUp7b^I&ta%Q3WY5{lhz^<9>gKmBy=c$-ueWK6mszkBzSOe>&;p?SRnV-
z9NNF$D7UC`vrAE1vc=>b=(Sd`W1HI%iXC|NAZo50%Q`Gj_mgz2D^2X#N5-9Pb4r|!
zcDuQJTeID~uCukhq0vr<yRz83P$rVJebD&IVgFdlTHDb1(&taK&#L}jz)7JjXiH|s
zuV!~yzOHUg%>3cQ&g4Da&v6ai*Iq}J9ZTqPPbsFUAXkS+F(+T~CM9%jBV+eYxC2v%
z+w7Yijpo~18~KbRcmIvsrR&iNHm=`D>cOK_(j7m&U3BEtZq}xbLNfMc`qB;TKi&m|
zU2x4Nc-&hn8e7|2YOkF!YnlyI(U(PiJ*N25E6Wpj-i9ZRd%^Y_UQQxuhnkU>Q<h&+
zo|k7Uv=tSV?1-DWAb3v+@0k_<>#Bd<D`Z*RQ&TMaE6V)zw}m2s{BN!IHi=~HdDh6k
zVxjaHFVH~GvwT@7&GnufpL!kkI{nkNm~|^Zy>pP^45qs~=F6pJ;X(-};|>fRAk<k}
zLBnDm{a9M1wM|o$1r=r4irIPo>M3<=nCLsCGE(~_?=HP>gNLy&W$)AVk#uq6|F`Az
zZTXt(HFo`XVpi1u{!UStZ<4Xe-`y>rPml3nWV#gTFhW#%(nT)6O6tBQlKbQ7;|;mg
zpC1!eb2b8zF3|q|B2wS8By`~bZ@%&oz<s<GH#Ivx3agafA;wrTvHhz_JtEQOjY%{%
zw2IULJ;nIV^t~m9B)@??2ej-ZTCjNqxrWne_t8}>LD_rYMW%5GEtGd6g^~vhG20J~
zKKGdV#F>Yk@@J1+Fs&r1-V$j4TO+2?uIePJ-Tyj$IXsVE_~3roe>=&8p1Cfe3>Vj0
z-2eH9ryb8)W%V(}$Xio|FQJ8shiqg%7C}!PDIn>%O6NwbWL3|Rm@nNB-(1|6uB0DL
zg3nK>f7nsv?_WIAL3ib6P}0CV0asr~Hz-zhj;KhdT(EW6FYXbDEh<KcY`_(i|HF_2
zD>*u7QOqY|7%L~EKLtyzrHPXk%02le9e=-uCQc_))ktT+wpZKY>CO>7dmbI@<kRX6
z820Zv{@+NZlD3uHQsYl+3Zs3oXS@-g?oAZWrYV6d!87Fsb}(T4M4uC$TSGDT7XMov
Fe*vaE82tbM

delta 2802
zcmdUxdrVVj6u|Fydx3&bTPd_6Vrd0I!L*7XDsl${32{ILDVw}s%0OYfgoeol_Aq;7
zwuiaJxecqy9+{i=MzbJjReWtzNi=a!Ec%C=+te8NLpSZthnH+_i`%lqWjFb8PS5%7
zz2|jL5WbcPy|OJvFsA#el?<b07)FNN^>{oe7_#><9UEZm_j_Z{IkFrLLMB*QD~X12
z)<eo+TxKAlHnV}7gFfInZPHX!@Mcd0N;49U<RHNawNH~I)n`k3BFbe52fMjhB*bQ(
zL1Jy@z;GJH<P|2J<t6zD$`tVON-)nrEf86S<RW><Y9t?7gFKGh!N)v-l0LBzWf4-0
zlpv)@8B&f^AQqds$<D4M9E7v86gT|JIhwp4J-<mlTTTO;k4ESl(Secmhc;OUt%%Q@
z&M9aPLR3fqqDE-m3Pgj@TMa0^5G*<~9g!om5bE=n<Pu3PmZYB~XQG^}O(g0%$xiQ$
zqOYb(G#ck3^N<(>_Q<tq3sG5w&;#)(6OhUJQQK1doh12_C7CKo>Zezw&72FRzDCnJ
zbW|g25gJYn$|sRpqz+k+Y(VOf2BgYnPPY5?dC{|X_m-_8_y15ddw+(fIuu}4Sjnd_
zuIMD6K+Dul|5Iq@5PI1asgTN>{`9CSm!svDIwB{hU|e;Mqt%==!Pqo`ltN2jrx$I#
zTD%ohK~x2((kY=6LMNsWx`G3ZbS7x1bS5g1Dr7QUnkG$mA{Ckr0(&%CZ4(-skrt#C
z*@#f5=+^YI<S4X+bb7a;&FKTTLvE8gaeT%UZ|AgTa(`6eQ)NN)wjn%v3^|URKu*%g
zl&4WUgPcV!AizfyD6gRME%F_54H4gsDB$esRNska`=DjA2&5KT)LD=kR0O&pw|(vy
zDT492J?z*Nu+G~IEZ<0K#TNcW;*1$1Ui35J9$KBit<gE+SbK&Zc14DY%QKG<hmp1C
zH2<M?{&d8CVDS%Ljs>hEly%1IS<uhX%O{otnkO@c=I(4rRhVF`JCCCq>Q_gP<mibJ
zbzyGeSi(9pbgZb;xruYOoc!A^0CvH#jQw4apL4#{=SAe=4qFN5Xl5N-<?xn84>`lZ
zpga-^nU|GNP!|$FCy(w2DlKp^D;d_UX@xe6R!+Z$UIa+Aj&onb;TuiU!ltXUK`2(k
z&5Jr;>ZN<97Y2)SWNz&Wn4fJF`4WLRtgO9U;20xggwniFaO7)!=(e&m6}a(&KwTUO
z2Wz~6FLQ}Pc?=6F!)iY#4p1N-k}=?EiwC}XP?c?2Z|lF+apin>qu-C`TMsa}vc>SV
zVMJvdY)mQ%+p+uQ?Y*Nv@!U4*fr@oS_Nv^7N>f5&yeYQ2YLO{6E<Ua@Hqm4<#a6_X
zRhvwe36+V7Wlwi}06SVUK&a^hUAMuP{Nrx=U&2Vo5PCtEQ3IN~8gNxb!}S9yh_11~
za7Q}CbOpi}by4un`q%zeR5G~J)(EZ*E~syxuK(*i;QjVA=QCqOJ@EzI3x;WoO{uT1
zZ7PJ_?YWTIk)~Q9IdECKsIG>-j#q%+=)y?^Q;h*u?faY*it_}HI9~9E8$vd0>Z%B+
z#|_hngHgp4GL1mK-v?U<mGJ1mG8_Wlnche4O_%>eoU8xCQ0)}nBmc!9<iq~<%m?@T
zzGm+y5A1M0c3TbX@n9Jp@HgE_J_Tp#KL-qqx)Xsv7zHV#S~3&54kb@4l+dAFFp^hJ
zLc}{)Wd!)6rDQvV=O>E9=^?}ecSj;&%kXldfg)EjyM?Zme0aTov3TaNoTyhbO-#eb
zXI_2Q_5A5gR{MpXYuY5p8EU|9;V>**H66Yjs&;O6VPS^^k?%)^Kemz;=u;MeFyMkC
zE8}pVg^_Le&ZY44hGGm`2_Ky>?-ULa`$-;Lhj`GBW{Fu}-6T8t<M^bJ0b-vxJy0VD
z{-g_rkLg6KTS-VCnxBG<OK~I}%3KEca5Rc-pzjJ5`ELXQHxDlXi%E;G;4m8lyuFrI
O$rr9)+6a!zi+=$Tr?LtF

diff --git a/Azure File Storage.js b/Azure File Storage.js
index a8db41c52..383c139d4 100644
--- a/Azure File Storage.js	
+++ b/Azure File Storage.js	
@@ -1,6 +1,8 @@
 
 exports.newAzureFileStorage = function newAzureFileStorage(BOT) {
 
+    const FULL_LOG = true;
+
     let bot = BOT;
     const ROOT_DIR = './';
 
@@ -109,22 +111,37 @@ exports.newAzureFileStorage = function newAzureFileStorage(BOT) {
 
         if (fileService === undefined) {
 
-            const logText = "[ERROR] initialize function not executed or failed. Can not process this request. Sorry.";
-            logger.write(logText);
+            logger.write("[ERROR] initialize function not executed or failed. Can not process this request. Sorry.");
             return;
         }
 
         try {
 
+            if (FULL_LOG === true) {
+
+                logger.write("[INFO] createTextFile about to createFileFromText here:");
+                logger.write("[INFO] SHARE NAME = " + shareName + " FOLDER PATH = " + folderPath + " FILE NAME = " + fileName);
+
+            }
+
             fileService.createFileFromText(shareName, folderPath, fileName, fileContent, onFileCreated);
 
             function onFileCreated(err, result, response) {
 
+                if (FULL_LOG === true) {
+
+                    logger.write("[INFO] SHARE NAME = " + shareName + " FOLDER PATH = " + folderPath + " FILE NAME = " + fileName);
+                    logger.write("[INFO] createTextFile - onFileCreated: err = " + JSON.stringify(err));
+                    logger.write("[INFO] createTextFile - onFileCreated: result = " + JSON.stringify(result));
+                    logger.write("[INFO] createTextFile - onFileCreated: response = " + JSON.stringify(response));
+
+                }
+
                 if (err) {
 
-                    const logText = "[WARN] createTextFile - onFileCreated ' ERROR = " + err.message + " SHARE NAME = " + shareName + " FOLDER PATH = " + folderPath + " FILE NAME = " + fileName;
-                    console.log(logText);
-                    logger.write(logText);
+                    logger.write("[ERR] createTextFile - onFileCreated: err = " + JSON.stringify(err));
+                    logger.write("[ERR] createTextFile - onFileCreated: result = " + JSON.stringify(result));
+                    logger.write("[ERR] createTextFile - onFileCreated: response = " + JSON.stringify(response));
 
                     if (err.message.indexOf("The server is busy") > 0) {
 
@@ -134,28 +151,28 @@ exports.newAzureFileStorage = function newAzureFileStorage(BOT) {
 
                             if (err) {
 
-                                const logText = "[ERROR] createTextFile - onFileCreated - onFileCreatedSecondTry : File not created. Giving Up.' ERROR = " + err.message + " SHARE NAME = " + shareName + " FOLDER PATH = " + folderPath + " FILE NAME = " + fileName;
-                                console.log(logText);
-                                logger.write(logText);
+                                logger.write("[ERR] createTextFile - onFileCreated - onFileCreatedSecondTry : File not created. Giving Up. ");
 
                             } else {
 
-                                const logText = "[INFO] createTextFile - onFileCreated - onFileCreatedSecondTry ' : File succesfully created on second try. SHARE NAME = " + shareName + " FOLDER PATH = " + folderPath + " FILE NAME = " + fileName;
-                                console.log(logText);
-                                logger.write(logText);
+                                logger.write("[INFO] createTextFile - onFileCreated - onFileCreatedSecondTry : File succesfully created on second try. ");
+                                logger.write("[INFO] SHARE NAME = " + shareName + " FOLDER PATH = " + folderPath + " FILE NAME = " + fileName);
 
                             }
                         }
                     }
+
+                    callBackFunction(false);
+
+                } else {
+
+                    callBackFunction(true);
+
                 }
-
-                callBackFunction();
             }
-
         }
         catch (err) {
-            const logText = "[ERROR] 'createTextFile' - ERROR : " + err.message;
-            logger.write(logText);
+            logger.write("[ERROR] 'createTextFile' - ERROR : " + JSON.stringify(err));
         }
 
     }