From 13ad9b4e397fbeded46b940aba95d4f6beaa7fd9 Mon Sep 17 00:00:00 2001 From: Nikola Bjelo Date: Sun, 28 Oct 2018 13:29:40 +0100 Subject: [PATCH] Correcting a little error in the error system --- server/src/schema/mutations/EditPrize.js | 3 ++- server/src/schema/mutations/EditRule.js | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/server/src/schema/mutations/EditPrize.js b/server/src/schema/mutations/EditPrize.js index 51515f61b..70a033f3b 100644 --- a/server/src/schema/mutations/EditPrize.js +++ b/server/src/schema/mutations/EditPrize.js @@ -25,7 +25,7 @@ const resolve = (parent, { eventDesignator, rank, amount }, context) => { } else if (!event) { reject(new DatabaseError('None of the events you own respond to that designator')) } else { - let prizeIndex + let prizeIndex = null event.prizes.find((prize, index) => { if (prize.rank === rank) { prizeIndex = index @@ -33,6 +33,7 @@ const resolve = (parent, { eventDesignator, rank, amount }, context) => { }) if (!prizeIndex) { reject(new DatabaseError('There is no prize for that index')) + return } event.prizes[prizeIndex].amount = amount || event.prizes[prizeIndex].amount event.save((err) => { diff --git a/server/src/schema/mutations/EditRule.js b/server/src/schema/mutations/EditRule.js index acf83460b..d772dc011 100644 --- a/server/src/schema/mutations/EditRule.js +++ b/server/src/schema/mutations/EditRule.js @@ -26,7 +26,7 @@ const resolve = (parent, { eventDesignator, title, newtitle, description }, cont } else if (!event) { reject(new DatabaseError('None of the events you own respond to that designator')) } else { - let ruleIndex + let ruleIndex = null event.rules.find((rule, index) => { if (rule.title === title) { ruleIndex = index @@ -34,6 +34,7 @@ const resolve = (parent, { eventDesignator, title, newtitle, description }, cont }) if (!ruleIndex) { reject(new DatabaseError('There is no rule with that title')) + return } event.rules[ruleIndex].description = description || event.rules[ruleIndex].description if (event.rules.some(rule => rule.title === newtitle)) {